Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump ruff>=0.6.0 #3539

Merged
merged 2 commits into from
Aug 15, 2024
Merged

ci: bump ruff>=0.6.0 #3539

merged 2 commits into from
Aug 15, 2024

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned added the dependencies Pull requests that update a dependency file label Aug 15, 2024
@dangotbanned dangotbanned merged commit 4a4d20d into vega:main Aug 15, 2024
13 checks passed
@dangotbanned dangotbanned deleted the bump-ruff-v060 branch August 15, 2024 14:24
@joelostblom
Copy link
Contributor

Just a note if you wonder why I added an additional label to this PR @dangotbanned . We try to always have one of the labels listed here on each PR: https://github.com/vega/altair/blob/main/.github/release.yml. GitHub then organize each PR into its corresponding section of the release notes automatically when creating the release via GitHub's interface. I don't have a strong opinion about labels not listed there, so feel free to add more to that list if there are some additional labels/sections you think would be useful.

I looked into automating the addition of a label to each PR via a GitHub action based on the conventional commit type mentioned in the PR title, but there was no such action so I just check through the closed PRs every now and then and label the ones that are missing one of the four labels our release notes are based on.

@dangotbanned
Copy link
Member Author

No worries @joelostblom

I won't be able to test right now, but https://github.com/vega/altair/blob/main/.github/release.yml looks like you can map multiple labels to each title?

E.g. this had the dependencies label, which could fall under maintenance.

If that can work, I think that would be worth doing as there are other labels that wouldnt be picked up currently

@joelostblom
Copy link
Contributor

Yup, we can map additional labels just like you said. Another option would be to remove the labels we haven't used much in the past like dependencies and usability. I don't really have a preference since I mostly use the four other labels, but if you believe that these additional labels are useful, then I'm happy for them to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants